From 7b80afac0d57c7217b3398b29ef431b6294ecebd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?L=C3=A9ana=20=E6=B1=9F?= <leana.jiang+git@icloud.com>
Date: Wed, 2 Jul 2025 08:48:19 +0200
Subject: [PATCH] firefox: reworked default configuration

---
 nix/homeModules/common/firefox.nix | 62 ++++++++++++++++++------------
 1 file changed, 37 insertions(+), 25 deletions(-)

diff --git a/nix/homeModules/common/firefox.nix b/nix/homeModules/common/firefox.nix
index 9070efc3..f6936818 100644
--- a/nix/homeModules/common/firefox.nix
+++ b/nix/homeModules/common/firefox.nix
@@ -3,41 +3,21 @@
 in {
   programs.firefox = {
     # https://mozilla.github.io/policy-templates
+    # The following have more complex logic, keep them as policies and not profiles
     policies = {
       SearchEngines = {
         Remove = ["Bing" "DuckDuckGo" "Qwant" "eBay"];
       };
-      HardwareAcceleration = true;
-      DisableFirefoxScreenshots = false;
-      DisablePocket = true;
+      NoDefaultBookmarks = true;
       DisplayMenuBar = "never";
       DisplayBookmarksToolbar = "never";
-      NoDefaultBookmarks = true;
-      OfferToSaveLogins = false;
-      OfferToSaveLoginsDefault = false;
-      PasswordManagerEnabled = false;
-      FirefoxHome = {
-        # https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/Policies.sys.mjs
-        Search = true;
-        TopSites = true;
-        SponsoredTopSites = false;
-        Highlights = false;
-        Pocket = false;
-        SponsoredPocket = false;
-
-        # "Thought provoking stories"
-        Stories = false;
-        SponsoredStories = false;
-      };
-      UserMessaging = {
-        ExtensionRecommendations = false;
-        SkipOnboarding = true;
-      };
       DNSOverHTTPS = {
         Enabled = true;
       };
     };
 
+    # https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/Policies.sys.mjs
+    # Some policies can be rewritten to profiles configuration
     profiles.default = {
       settings = {
         "toolkit.legacyUserProfileCustomizations.stylesheets" = true;
@@ -46,9 +26,41 @@ in {
         "layout.css.devPixelsPerPx" = 1.1;
         "full-screen-api.ignore-widgets" = true; # limit fullscreen mode to window
 
-        # "Thought provoking stories"
+        # Sponsored crap
+        # Yes
+        "browser.newtabpage.activity-stream.showSearch" = true;
+        "browser.newtabpage.activity-stream.feeds.topsites" = true;
+        # No
+        "browser.newtabpage.activity-stream.showSponsoredTopSites" = false;
+        "browser.newtabpage.activity-stream.feeds.section.highlights" = false;
+        "browser.newtabpage.activity-stream.feeds.system.topstories" = false;
         "browser.newtabpage.activity-stream.feeds.section.topstories" = false;
         "browser.newtabpage.activity-stream.showSponsored" = false;
+
+        # URL
+        # Yes
+        "browser.urlbar.suggest.quicksuggest.nonsponsored" = true;
+        # No
+        "browser.urlbar.suggest.quicksuggest.sponsored" = false;
+
+        # Pasword manager
+        "signon.rememberSignons" = false;
+        "services.passwordSavingEnabled" = false;
+        "pref.privacy.disable_button.view_passwords" = false;
+
+        # Hardware acceleration
+        "layers.acceleration.disabled" = false;
+
+        # Screenshot
+        "screenshots.browser.component.enabled" = true;
+
+        # Recommendations
+        "browser.newtabpage.activity-stream.asrouter.userprefs.cfr.addons" = false;
+        "browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features" = false;
+        "extensions.htmlaboutaddons.recommendations.enabled" = false; # Addons
+
+        # Onboarding
+        "browser.aboutwelcome.enabled" = false;
       };
 
       extensions.packages = let